file: add file_system_stat #2530
Open
+71
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benny Halevy <[email protected]>
Return an abstract file_system_stat_data representing the system statvfs for the filesystem identified by the given file name. The motivation is implementing a disk-space monitor in scylladb. Signed-off-by: Benny Halevy <[email protected]>
|
|
@xemul can you please review and consider merging? |
|
This PR adds
So basically it adds 1:1 wrapper over existing APIs. What's the point? |
The wrapper is similar to other "global" entry points we have so that callers won't need to access the reactor api. As for the abstract file_system_stat_data, again, it's similar to the file stat_data struct that is not linux specific and provides an isolation layer. Users don't need to know about the crazy linux/posix semantics on statvfs regarding the lock size or fragment size and how they relate to total/free/available blocks in the filesystem. It's too system specific. |
|
ping @xemul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an abstract file_system_stat_data representing
the system statvfs for the filesystem identified
by the given file name.
The motivation is implementing a disk-space monitor
in scylladb.