reloc/build_reloc.sh: don't use --no-build-isolation
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov if you can take this to a ride, to see it solve the issue this repo CI, doesn't cover the packaging part that is used only by scylla-core |
tchaikov
reviewed
May 9, 2024
pyproject.toml
Outdated
| @@ -2,11 +2,11 @@ | |||
| requires = [ | |||
| "setuptools>=42", | |||
| "wheel", | |||
| "Cython", | |||
| "Cython<3", | |||
There was a problem hiding this comment.
it turns out this change is not necessary anymore with the other changes in this commit.
for downloading the source packages dependecies, we use the `pip download` command and we uses `--no-build-isolation` which mean it doesn't download it's own set of versions, with using using `--no-binary :all:` to download the source packages but that's affect also the build dependency which would make it extremely slow, compile cython from source. so first pin the cython in the build dependecies, and force the command download cython always as wheel to avoid building it from source Fixes: scylladb#78
fruch
force-pushed
the
fix_packaging_py3.12
branch
from
97616db
to
8dac3db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for downloading the source packages dependecies, we use the
pip downloadcommandand we uses
--no-build-isolationwhich mean it doesn't download it's own set of versions, with using using--no-binary :all:to download the source packagesbut that's affect also the build dependency which would make it extremely slow, compile cython from source.
so first pin the cython in the build dependecies, and force the command download cython always as wheel to avoid building it from source
Fixes: #78