Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model best state #887

Merged
merged 2 commits into from
Jan 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 99 additions & 0 deletions scvi/lightning/_callbacks.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import warnings

import numpy as np
import torch
from pytorch_lightning.callbacks import Callback
from pytorch_lightning.utilities import rank_zero_info


class SubSampleLabels(Callback):
Expand All @@ -8,3 +13,97 @@ def __init__(self):
def on_epoch_start(self, trainer, pl_module):
trainer.train_dataloader.resample_labels()
super().on_epoch_start(trainer, pl_module)


class SaveBestState(Callback):
r"""
Save the best model state and restore into model.

Parameters
----------
monitor
quantity to monitor.
verbose
verbosity, True or False.
mode
one of ["min", "max"].
period
Interval (number of epochs) between checkpoints.

Examples
--------
from scvi.lightning import Trainer
from scvi.lightning import SaveBestState
"""

def __init__(
self,
monitor: str = "elbo_validation",
mode: str = "min",
verbose=False,
period=1,
):
super().__init__()

self.monitor = monitor
self.verbose = verbose
self.period = period
self.epochs_since_last_check = 0
self.best_model_state = None

if mode not in ["min", "max"]:
raise ValueError(
f"SaveBestState mode {mode} is unknown",
)

if mode == "min":
self.monitor_op = np.less
self.best_model_metric_val = np.Inf
self.mode = "min"
elif mode == "max":
self.monitor_op = np.greater
self.best_model_metric_val = -np.Inf
self.mode = "max"
else:
if "acc" in self.monitor or self.monitor.startswith("fmeasure"):
self.monitor_op = np.greater
self.best_model_metric_val = -np.Inf
self.mode = "max"
else:
self.monitor_op = np.less
self.best_model_metric_val = np.Inf
self.mode = "min"

def check_monitor_top(self, current):
return self.monitor_op(current, self.best_model_metric_val)

def on_epoch_end(self, trainer, pl_module):
logs = trainer.callback_metrics
self.epochs_since_last_check += 1

if self.epochs_since_last_check >= self.period:
self.epochs_since_last_check = 0
current = logs.get(self.monitor)

if current is None:
warnings.warn(
f"Can save best model state only with {self.monitor} available,"
" skipping.",
RuntimeWarning,
)
else:
if isinstance(current, torch.Tensor):
current = current.item()
if self.check_monitor_top(current):
self.best_model_state = pl_module.model.state_dict()
self.best_model_metric_val = current

if self.verbose:
rank_zero_info(
f"\nEpoch {trainer.current_epoch:05d}: {self.monitor} reached."
f" Model best state updated."
)

def on_train_end(self, trainer, pl_module):

pl_module.model.load_state_dict(self.best_model_state)
12 changes: 12 additions & 0 deletions tests/models/test_lightning.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
from scvi.data import synthetic_iid
from scvi.model import SCVI
from scvi.lightning._callbacks import SaveBestState


def test_save_best_state_callback(save_path):

n_latent = 5
adata = synthetic_iid()
model = SCVI(adata, n_latent=n_latent)
callbacks = [SaveBestState(verbose=True)]
model.train(3, check_val_every_n_epoch=1, train_size=0.5, callbacks=callbacks)