Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decipher Trajectory methods #3092

Merged
merged 7 commits into from
Dec 21, 2024

Conversation

justjhong
Copy link
Contributor

Implements the methods that require a pre-computed trajectory onto the Decipher model class.

cc @ANazaret

@justjhong justjhong requested a review from canergen December 13, 2024 03:58
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (jhong/deciphermethods@a5c3487). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/scvi/external/decipher/_model.py 93.10% 2 Missing ⚠️
src/scvi/external/decipher/utils/_trajectory.py 97.56% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             jhong/deciphermethods    #3092   +/-   ##
========================================================
  Coverage                         ?   84.71%           
========================================================
  Files                            ?      181           
  Lines                            ?    15259           
  Branches                         ?        0           
========================================================
  Hits                             ?    12927           
  Misses                           ?     2332           
  Partials                         ?        0           
Files with missing lines Coverage Δ
src/scvi/external/decipher/utils/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/decipher/utils/_rotate.py 87.50% <ø> (ø)
src/scvi/external/decipher/utils/_trajectory.py 97.56% <97.56%> (ø)
src/scvi/external/decipher/_model.py 96.11% <93.10%> (ø)

@canergen
Copy link
Member

LGTM. See two point above, fix pre-commit missing empty line and add CHANGELOG.

@justjhong justjhong merged commit 2056f77 into jhong/deciphermethods Dec 21, 2024
4 of 5 checks passed
@justjhong justjhong deleted the jhong/deciphertrajectory branch December 21, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants