Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change template for HuggingFace. #3078

Merged
merged 38 commits into from
Dec 24, 2024
Merged

feat: Change template for HuggingFace. #3078

merged 38 commits into from
Dec 24, 2024

Conversation

canergen
Copy link
Member

@canergen canergen commented Dec 4, 2024

No description provided.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 79.35943% with 58 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (8c24d75) to head (12676e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/hub/_model.py 68.42% 24 Missing ⚠️
src/scvi/criticism/_create_criticism_report.py 82.22% 16 Missing ⚠️
src/scvi/hub/_metadata.py 59.25% 11 Missing ⚠️
src/scvi/criticism/_ppc.py 87.50% 5 Missing ⚠️
src/scvi/data/_manager.py 95.45% 1 Missing ⚠️
src/scvi/module/_vaec.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3078      +/-   ##
==========================================
+ Coverage   83.27%   83.69%   +0.41%     
==========================================
  Files         180      181       +1     
  Lines       15187    15386     +199     
==========================================
+ Hits        12647    12877     +230     
+ Misses       2540     2509      -31     
Files with missing lines Coverage Δ
src/scvi/criticism/__init__.py 100.00% <100.00%> (ø)
src/scvi/hub/_constants.py 100.00% <100.00%> (ø)
src/scvi/hub/_template.py 100.00% <100.00%> (ø)
src/scvi/model/_totalvi.py 87.82% <100.00%> (+0.53%) ⬆️
src/scvi/data/_manager.py 95.75% <95.45%> (-0.37%) ⬇️
src/scvi/module/_vaec.py 88.37% <0.00%> (+2.97%) ⬆️
src/scvi/criticism/_ppc.py 86.29% <87.50%> (-2.19%) ⬇️
src/scvi/hub/_metadata.py 85.00% <59.25%> (-7.56%) ⬇️
src/scvi/criticism/_create_criticism_report.py 82.22% <82.22%> (ø)
src/scvi/hub/_model.py 84.83% <68.42%> (+26.77%) ⬆️

... and 1 file with indirect coverage changes

@canergen canergen added the private tests Run private tests label Dec 4, 2024
@canergen canergen changed the title Change template for HuggingFace. feat: Change template for HuggingFace. Dec 4, 2024
@canergen canergen added the cuda tests Run test suite on CUDA label Dec 23, 2024
@canergen canergen added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Dec 24, 2024
@canergen canergen merged commit cf0af33 into main Dec 24, 2024
12 of 15 checks passed
Copy link

lumberbot-app bot commented Dec 24, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 cf0af3385de0715a07960a56b13eaae042bad0f5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3078: feat: Change template for HuggingFace.'
  1. Push to a named branch:
git push YOURFORK 1.2.x:auto-backport-of-pr-3078-on-1.2.x
  1. Create a PR against branch 1.2.x, I would have named this PR:

"Backport PR #3078 on branch 1.2.x (feat: Change template for HuggingFace.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

ori-kron-wis added a commit that referenced this pull request Dec 24, 2024
Re: [scverse/scvi-tools] feat: Change template for HuggingFace. (PR
#3078)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ori-kron-wis <[email protected]>
Co-authored-by: Lumberbot (aka Jack) <[email protected]>
Co-authored-by: Martin Kim <[email protected]>
Co-authored-by: Can Ergen <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Justin Hong <[email protected]>
Co-authored-by: Ethan Weinberger <[email protected]>
Co-authored-by: Ethan Weinberger <[email protected]>
Co-authored-by: access <[email protected]>
Co-authored-by: Yishen Miao <[email protected]>
Co-authored-by: Ramon Viñas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda tests Run test suite on CUDA hub on-merge: backport to 1.2.x on-merge: backport to 1.2.x private tests Run private tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants