Quick fix in poisson sample() function for vae #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld have caught it for the scvi model
Codecov ReportBase: 91.32% // Head: 91.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
+ Coverage 91.32% 91.39% +0.07%
==========================================
Files 116 116
Lines 9206 9205 -1
==========================================
+ Hits 8407 8413 +6
+ Misses 799 792 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adamgayoso
approved these changes
Sep 20, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/scvi-tools
that referenced
this pull request
Sep 20, 2022
adamgayoso
pushed a commit
that referenced
this pull request
Sep 20, 2022
) Co-authored-by: ricomnl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed poisson sampling in vae's sample() function, wrote test that would have caught it for the scvi model