Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove poetry lock, use newer build system #1645

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Remove poetry lock, use newer build system #1645

merged 1 commit into from
Aug 22, 2022

Conversation

adamgayoso
Copy link
Member

@adamgayoso adamgayoso commented Aug 22, 2022

  • Update poetry build system
  • Remove lock file, as it's not useful given the many number of ways pytorch/jax can be installed

The first change still allows pip install -e . and this is the recommended way to install (in a virtualenv)

See python-poetry/poetry#34 for more discussion (specifically the end)

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1645 (d2a67c9) into master (4f00985) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         116      116           
  Lines        9193     9193           
=======================================
  Hits         8390     8390           
  Misses        803      803           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@watiss
Copy link
Contributor

watiss commented Aug 22, 2022

Do we need to update scvi documentation https://docs.scvi-tools.org/en/stable/contributing/index.html ?

@adamgayoso
Copy link
Member Author

Do we need to update scvi documentation https://docs.scvi-tools.org/en/stable/contributing/index.html ?

Nope, all these things still work, maybe the poetry install is not recommended, but I think this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants