Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin memory False! #1473

Merged
merged 1 commit into from
Mar 29, 2022
Merged

pin memory False! #1473

merged 1 commit into from
Mar 29, 2022

Conversation

adamgayoso
Copy link
Member

Turns out this doesn't really make things faster, and really messes things up in shared environments.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1473 (7a80669) into master (5f908b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1473   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         111      111           
  Lines        8764     8764           
=======================================
  Hits         7978     7978           
  Misses        786      786           
Impacted Files Coverage Δ
scvi/_settings.py 83.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f908b2...7a80669. Read the comment docs.

@adamgayoso adamgayoso merged commit 70f47ea into master Mar 29, 2022
@adamgayoso adamgayoso deleted the pin_mem branch March 29, 2022 18:02
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 29, 2022
adamgayoso added a commit that referenced this pull request Mar 29, 2022
@adamgayoso
Copy link
Member Author

@meeseeksdev backport to 0.16.x

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 7, 2022

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants