Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1458 on branch 0.15.x (SCANVI bug fixes) #1459

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #1458: SCANVI bug fixes

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #1459 (116fe44) into 0.15.x (56d3ece) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           0.15.x    #1459      +/-   ##
==========================================
+ Coverage   90.97%   91.04%   +0.06%     
==========================================
  Files         111      111              
  Lines        8743     8762      +19     
==========================================
+ Hits         7954     7977      +23     
+ Misses        789      785       -4     
Impacted Files Coverage Δ
scvi/data/fields/_scanvi.py 100.00% <100.00%> (+3.12%) ⬆️
scvi/model/_scanvi.py 93.79% <100.00%> (+0.19%) ⬆️
scvi/model/base/_archesmixin.py 90.76% <100.00%> (+0.21%) ⬆️
scvi/module/_scanvae.py 80.50% <100.00%> (+1.80%) ⬆️
scvi/module/_vae.py 93.99% <100.00%> (+0.85%) ⬆️
scvi/data/_utils.py 86.27% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d3ece...116fe44. Read the comment docs.

@adamgayoso
Copy link
Member

@jjhong922 reason this fails is a new jinja release on pypi has some breaking changes in nbsphinx. We can just wait it out

@adamgayoso adamgayoso merged commit e192178 into scverse:0.15.x Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants