-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thorough use of distributions to clean module-level code #1356
Merged
Merged
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9884cda
replace normal parameters in inference by distribution
PierreBoyeau 998c345
totalVI changes
PierreBoyeau 2a0c1d1
Merge branch 'master' of https://github.com/YosefLab/scvi-tools into …
PierreBoyeau c9bf152
merge fixes
PierreBoyeau c1ebcd4
fix totalvi
PierreBoyeau 493ff5d
fixes
PierreBoyeau 0e1d07f
fix gimvi
PierreBoyeau 3761bb6
merge from main
PierreBoyeau abffd8f
pyro
PierreBoyeau ce1b4b4
clean
PierreBoyeau 1227323
clean
PierreBoyeau 7d9be42
dummy
PierreBoyeau 41d9b0f
log prob sum
PierreBoyeau 4868898
fix conversion
PierreBoyeau 6566c0e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 65df0aa
simplication log_prob_sum
PierreBoyeau de172e7
rename px
PierreBoyeau ea225a5
px
PierreBoyeau fbae55f
Optional return_dist
PierreBoyeau 04c4138
Merge branch 'master' of https://github.com/YosefLab/scvi-tools into …
PierreBoyeau fedf805
feat generative refactor
PierreBoyeau 5f48f0e
updates
PierreBoyeau dd2cd8b
precommit
PierreBoyeau a480774
Merge branch 'master' of https://github.com/scverse/scvi-tools into d…
PierreBoyeau af84491
docstring
PierreBoyeau 6e205ea
docstring
PierreBoyeau 63ee149
docstring
PierreBoyeau 43b74ee
Merge branch 'master' of https://github.com/scverse/scvi-tools into d…
PierreBoyeau c581d14
release note
PierreBoyeau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve docs on optional args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry wasnt clear, just meant to expand on the definitions which looks good now. You can remove ": optional" because sphinx takes care of that for us