Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update black version #1317

Merged
merged 2 commits into from
Jan 31, 2022
Merged

update black version #1317

merged 2 commits into from
Jan 31, 2022

Conversation

adamgayoso
Copy link
Member

they are now out of beta

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1317 (68d85cc) into master (cabbdac) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   90.64%   90.64%           
=======================================
  Files          97       97           
  Lines        7796     7796           
=======================================
  Hits         7067     7067           
  Misses        729      729           
Impacted Files Coverage Δ
scvi/distributions/_negative_binomial.py 87.11% <0.00%> (ø)
scvi/model/_metrics.py 47.69% <ø> (ø)
scvi/model/_totalvi.py 83.72% <100.00%> (ø)
scvi/module/_amortizedlda.py 100.00% <100.00%> (ø)
scvi/module/_multivae.py 88.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cabbdac...68d85cc. Read the comment docs.

@adamgayoso adamgayoso merged commit d96448b into master Jan 31, 2022
@adamgayoso adamgayoso deleted the black branch January 31, 2022 05:55
@adamgayoso
Copy link
Member Author

@meeseeksdev backport to 0.14.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 31, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.14.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 d96448b7473145fef6cf41798beccf2c87bae51b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1317: update black version'
  1. Push to a named branch:
git push YOURFORK 0.14.x:auto-backport-of-pr-1317-on-0.14.x
  1. Create a PR against branch 0.14.x, I would have named this PR:

"Backport PR #1317 on branch 0.14.x (update black version)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@adamgayoso
Copy link
Member Author

@jjhong922 can you handle this first thing Monday morning?

justjhong pushed a commit that referenced this pull request Feb 1, 2022
adamgayoso added a commit that referenced this pull request Feb 1, 2022
adamgayoso added a commit that referenced this pull request Feb 1, 2022
adamgayoso added a commit that referenced this pull request Feb 1, 2022
justjhong pushed a commit that referenced this pull request Feb 14, 2022
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
* update black release

* update pre commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant