Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accessibility): Move aria-live=polite to overlay container #934

Merged
merged 2 commits into from
Apr 18, 2022
Merged

feat(accessibility): Move aria-live=polite to overlay container #934

merged 2 commits into from
Apr 18, 2022

Commits on Apr 16, 2022

  1. Move aria-live="polite" to the overlay container, not the toasts 

    also updates the README.md to let authors know they'll need this attribute
if they're doing custom overlay containers
    @patrickhlauke
    patrickhlauke committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    d979ac0 View commit details
    Browse the repository at this point in the history

  2. Use role="alert" rather than role="alertdialog" 

    dialogs/alertdialogs are intended to receive focus when they're shown. toasts, by their very nature, are not meant to steal focus but happen in parallel/as an aside
    @patrickhlauke
    patrickhlauke committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    f459b99 View commit details
    Browse the repository at this point in the history