Bump substrate to polkadot-v0.9.19 #228
Conversation
Add Transactional Error Module specific error value of ModuleError has changed
| }) => { | ||
| let error = metadata.error(index, error)?; | ||
| let error = metadata.error(index, error[0])?; | ||
| Ok(Self::Module(PalletError { |
There was a problem hiding this comment.
ModuleError has changed https://github.com/paritytech/substrate/blob/580ebae17fa30082604f1c9720f6f4a1cfe95b50/primitives/runtime/src/lib.rs#L476
But it seems that 0 value of error corresponds to the previous index
There was a problem hiding this comment.
For documentation purpose, relevant PR: paritytech/substrate#10242
haerdib
left a comment
haerdib
left a comment
There was a problem hiding this comment.
LGTM. Only one uncertainity: As the substrate-api-client is used by others as well, should we merge the polkadot branch into the master? Or leave it as a branch?
@clangenb what's your opinion?
@echevrier can you rename the branhc (or create a new one, doesn't matter for me) to polkadot-v0.9.19 ? We should keep the naming consistent with substrate
| }) => { | ||
| let error = metadata.error(index, error)?; | ||
| let error = metadata.error(index, error[0])?; | ||
| Ok(Self::Module(PalletError { |
There was a problem hiding this comment.
For documentation purpose, relevant PR: paritytech/substrate#10242
Changes because of substrate: