Increased description size to 1000 characters #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default maximum description in Delicious was raised to 1000 characters instead of 255 several years ago. The current setting in Scuttle makes it impossible for users to import data from their Delicious account into Scuttle. When the limit is increased, the old text-box was a bit too small. This increases it (in line with what Delicious did when they made the change). In this patch, tables.sql is updated, but existing installations will need to alter their database table my hand. In the absense of a system for migrations, this seems to be able the best we can do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default maximum description in Delicious was raised to 1000 characters instead of 255 several years ago. The current setting in Scuttle makes it impossible for users to import data from their Delicious account into Scuttle.
When the limit is increased, the old text-box becomes rather too small. This increases it (in line with what Delicious did when they made the change).
In this patch, tables.sql is updated, but existing installations will need to alter their database table my hand. In the absence of a system for migrations, this seems to be able the best we can do.
That said, this patch should not break directly. It will allow people to submit longer items which will then be rejected (or just cropped to 255 characters, I suppose) by MySQL. As a result, this patch, if accepted, would need to be moved into the release notes.