Feat/sha3#46
Merged
Merged
Conversation
Author
roynalnaruto
added a commit
that referenced
this pull request
Jul 28, 2022
* feat: RLC Accumulator type for copy circuit row * fix: rlc accumulator calculation * fix: return tests fixed * Feat/sha3 (#46) * feat: initial changes * fix: rebase and fix return_ opcode as per new copy lookup api * feat: add copy and keccak lookup * tests: WIP test for sha3 * fix: sha3 tests for root tx * fix: actual sha3 is only over the bytes, not RLC'd bytes * fix: keccak table lookup as per docs * fix: avoid relying on dynamic rotations within copy lookup * chore: rename value_rlc to rlc_acc * fix: push opcode arguments * fix: comment for value constraint (RlcAcc case) * Update src/zkevm_specs/evm/execution/sha3.py Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com> * chore: use standard api for RLC instead of looping ad-hoc * fix: memory expansion coeff is 3 for all cases * docs: update specs to match new constraints and columns * docs: update table specs * fix: table layout for copy table in specs Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.