This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Fix: allow skipping of L1Msg tx part 2 i.e. calculate num_all_txs in tx circuit#764
Closed
kunxian-xia wants to merge 10 commits into
Closed
Fix: allow skipping of L1Msg tx part 2 i.e. calculate num_all_txs in tx circuit#764kunxian-xia wants to merge 10 commits into
kunxian-xia wants to merge 10 commits into
Conversation
icemelon
reviewed
Aug 15, 2023
icemelon
reviewed
Aug 15, 2023
4 tasks
Author
|
Close this as we have it rebased against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add constraints on tx.block_number in tx table. We group txs with same block number and then get the
num_all_txsin each group (i.e. block). Then we do lookup arg into block table in tx circuit. Since thenum_txsin pi's chunk data hash preimage meansnum_all_txsnow, we now copy it to theNumAllTxsrow in block table. That is, theNumTxsandCumNumTxsin block number is not constrained by pi circuit then.The lookup arg into block table in tx circuit are done at
tag == BlockNumrows and it looks as(NumAllTxs, tx_table.value, num_all_txs_acc).This is the 2nd part of the #760.
Issue Link
#759
Type of change