This repository was archived by the owner on Apr 18, 2025. It is now read-only.
add Busmapping coinbase code#58
Merged
Merged
Conversation
thanks ! |
0xmountaintop
force-pushed
the
busmapping_coinbase
branch
from
d29f459 to
e26b60c
Compare
0xmountaintop
approved these changes
Jan 6, 2022
icemelon
reviewed
Jan 7, 2022
Member
|
probably just merge this PR into the coinbase circuit one since it's quite simple, and you can then change the test cases in coinbase circuit using the busmapping |
Author
PR# 259 is in review status, maybe change afterwards, For now,I tend to keep them seperated before merged to reduce variable dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr base on privacy-ethereum#259
Busmapping related files:
bus-mapping/src/evm/opcodes/coinbase.rs
bus-mapping/src/evm/opcodes.rs