This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Upgrade 5#1445
Merged
Merged
Conversation
lispc
approved these changes
Nov 5, 2024
|
btw.. if i provide curie-chunk-circuit as HALO2_PROTOCOL, and darwin-chunk-circuit as SP1_PROTOCOL, actually the batch circuit can verify either curie chunks or darwin chunks? so if we think more generally, the batch circuit is just a one-in-many mixer. |
Author
Technically, yes. But as of the current changes the batch circuit supports only 2 variants, which I have called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The batch circuit now supports aggregation of chunk SNARKS (layer-2) that can belong to either of the following routes:
super circuit->compression circuit->compression circuitsp1->halo2-backend-> compression circuit`Prior, since only route 1 existed, the SNARK protocol was loaded as a constant. The fundamental change made in
snark-verifier(scroll-tech/snark-verifier#39) is to expose aaggregate_as_witnessmethod that loads the SNARK protocols as witness instead.In the batch circuit, we add the following constraints:
Type of change