Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Check that chunk_idx increases on boundaries #1173

Merged
roynalnaruto merged 3 commits into from
Mar 26, 2024
Merged

Check that chunk_idx increases on boundaries #1173

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3bde90
check that chunk_idx increases by at least 1 on boundaries
Mar 26, 2024
f1287c5
Add range check for chunk_idx
Mar 26, 2024
ce40591
Merge branch 'feat/blob-4844-da' into fix/chunk_idx
roynalnaruto Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion aggregator/src/aggregation/blob_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,18 @@ impl BlobDataConfig {
let cond = is_not_hash * is_boundary * (1.expr() - is_padding_next);
let chunk_idx_curr = meta.query_advice(config.chunk_idx, Rotation::cur());
let chunk_idx_next = meta.query_advice(config.chunk_idx, Rotation::next());
vec![(cond * (chunk_idx_next - chunk_idx_curr), range_table.into())]
// chunk_idx increases by at least 1 and at most MAX_AGG_SNARKS when condition is met.
vec![(cond * (chunk_idx_next - chunk_idx_curr - 1.expr()), config.chunk_idx_range_table.into())]
},
);

meta.lookup(
"chunk_idx for non-padding, data rows in [1..MAX_AGG_SNARKS]",
|meta| {
let is_data = meta.query_selector(config.data_selector);
let is_padding = meta.query_advice(config.is_padding, Rotation::cur());
let chunk_idx = meta.query_advice(config.chunk_idx, Rotation::cur());
vec![(is_data * (1.expr() - is_padding) * (chunk_idx - 1.expr()), config.chunk_idx_range_table.into())]
},
);

Expand Down