This repository was archived by the owner on Apr 18, 2025. It is now read-only.
forked from privacy-ethereum/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 387
epic: Blob 4844 DA #1153
Merged
Merged
epic: Blob 4844 DA #1153
Changes from 194 commits
Commits
Show all changes
198 commits
Select commit
Hold shift + click to select a range
62d5c22
chore: dependencies
roynalnaruto b3eb451
Rebase code to main dev branch
darth-cy 93c838e
Rebase code to main dev branch
darth-cy 5341fc6
Remove signed len
darth-cy 5990e52
basic constraints
roynalnaruto 56ea2f6
Add accumulation constraints
darth-cy 28e3267
Add chunk bytes to keccak and pow of rand to tx circuit config
darth-cy 46b7c33
Remove debug flags
darth-cy e648285
clippy
darth-cy ca6cc06
Correct keccak lookup
darth-cy 552d8f1
Add pow of rand lookup
darth-cy 955d86c
remove pow of rand from lookup config
darth-cy c649ceb
Change unusable rows
darth-cy a43c7f6
remove debug flags
darth-cy 15c8d2a
fmt
darth-cy bf694ed
correct export for pi circuit
darth-cy 4d61226
fmt
darth-cy 40fc5e0
patch halo2curves to branch that supports bls12_381
6da4380
Add roots of unity
52b2fa1
add barycentric evaluation constraints and assignments
50fa339
Call assign in circuit synthesis
94fe909
cleanup
9a9f0fb
replace local patches with github
80abce6
Correct column type
darth-cy d7b80a6
Add l1msg and padding tx len, hash acc conditions
darth-cy 9f67b5c
Define init condition for len, hash acc
darth-cy cb707ea
Remove access list and calldata constraints
darth-cy d2c5d84
Correct keccak lookup rotation
darth-cy a2073d3
Use fixed row to isolate last row of fixed section
darth-cy 8fbfa77
Remove hash consistency gate
darth-cy fd3eb12
chunk/batch definition updates
roynalnaruto e520d77
add txbytes to the keccak preimages
roynalnaruto fa4857a
blob data is actually the correct preimage for chalenge point
roynalnaruto 061a5d2
remove unused feature flag from patch
96a2110
implement Sum for ScalarFieldElement
8caec02
use sum
c03c4a9
use same range config between barycentric config and base field config
4b7b52a
cleanup
6e1fc70
Merge branch 'feat/4844-blob-data-config' into barycentric
03a803e
fix build
18d82e0
connect barycentric centric to aggregation circuit
1887839
Correct test 1559 parsing
darth-cy 202d40e
Recover constraints
darth-cy 41a326d
Remove debug flags
darth-cy 3da11c6
fmt
darth-cy ea0a900
Remove debug flag
darth-cy 9628f0f
Add forgotten file
3c82220
updated definition of random point
f8073a3
enable equality
darth-cy c995e43
Adjust equality-enabled columns
darth-cy f329efd
Adjust tx circuit output
darth-cy 4369fc0
Adjust equality-enabled columns
darth-cy 32a6783
Correct tx circuit hash output
darth-cy ff117bb
Change chunk data hash definition
darth-cy ef6bec7
wip
roynalnaruto 58d8d3e
Use same roots of unity as 4844 spec
8c4a7eb
constraints for rows at fixed offsets
roynalnaruto 3c1b2cf
digest bytes section
roynalnaruto 6a25d11
minor edit
roynalnaruto 435a821
fix: rows in data section
roynalnaruto 24523b7
cleanup
6d3361b
Add more blob tests
695d2bb
Use successors to calculate power of z
1cb4eeb
Merge branch 'feat/4844-blob-data-config' into barycentric
8de270b
Add chunk bytes in PI
darth-cy c16a2ee
Adjust sectional offsets
darth-cy 078032c
Change sectional note
darth-cy 3c551cc
add chunk txbytes assignment
darth-cy 6d440f8
Correct assignments
darth-cy ea27521
export assigned bytes from blob data
roynalnaruto b6571be
minor
roynalnaruto 91d068d
also export chunk data digest
roynalnaruto 45494a0
assign2 wip
roynalnaruto a4b9496
Add chunk txbytes hash to pi hash
darth-cy a84d6c9
Correct hash component
darth-cy 9072855
Correct data bytes assignment (padding)
darth-cy ff72ce2
Correct chunk txbytes padding assignments
darth-cy 5db2aeb
Correct boundary idx counting
darth-cy 6b71fa2
Add chunk txbytes to keccak inputs
darth-cy bd979ea
Correct coinbase and difficulty
darth-cy 8cba41b
fmt
darth-cy cb12ed3
Add BarycentricEvaluationAssignments and make inputs to barycentric e…
d7abc84
assign2 does some checks
roynalnaruto 768adcd
Merge branch 'feat/4844-blob-data-config' into barycentric
roynalnaruto 26473dc
equate exports of barycentric to exports of blob data config
roynalnaruto 6d6df25
also return the challenge (after modulus)
roynalnaruto df6ddd5
Control test suite
darth-cy b1c9115
fix challenge equality and export challenge/evaluation LE bytes
roynalnaruto beb40be
Adjust debugging suite
darth-cy 2ee9de4
Constraint differential
darth-cy 9a996d9
Constraint differential
darth-cy 82c1bce
Constraint differential
darth-cy fd15c7e
Correct column type'
darth-cy 34b9afa
Constraint differential
darth-cy 8e09113
Correct assignment spacing
darth-cy 8ba816e
Recover constraint
darth-cy 4931914
Test Differential
darth-cy 034b667
Remove debug flags
darth-cy 155aa49
Constraint differential
darth-cy fa43637
Add debug flags
darth-cy 32253cc
Correct idx increments
darth-cy 725e97f
update batch_pi_hash preimage to be blob-compatible
kunxian-xia da3cf7e
fix preimages' len
kunxian-xia 84c88fa
Adjust debug flags
darth-cy 0109b7c
Add debug flags
darth-cy f0c0fc8
Add debug flags
darth-cy d43180b
Adjust debug flags
darth-cy 1e6ed8f
fix batch_pi_hash input_len
kunxian-xia ab196c0
add equality between chunk_data_digests and chunk_pi_hash's preimage
kunxian-xia 3798fd4
fix: return assigned values instead of witness cells for challenge/ev…
roynalnaruto 0838626
Add new hash preimages
darth-cy ba419ee
Add borrow
darth-cy fc33c2b
Adjust imports
darth-cy 447dc0f
Remove debug flags
darth-cy 8842451
fmt
darth-cy f977a8c
Constraint depth consistency in longlist decoding
darth-cy 9bb6ef9
Revert "Constraint depth consistency in longlist decoding"
darth-cy 5ed8c1e
Recover variadic test
darth-cy a3bbc55
Merge remote-tracking branch 'scroll/barycentric' into feat/copy-blob…
kunxian-xia e42f975
enable z and y equality check
kunxian-xia a7cc333
apply comments
kunxian-xia ef17f0b
Correct mock data
darth-cy d31d59b
clippy
darth-cy bcf73a4
Add comments
darth-cy 98e2c16
fmt
darth-cy 34121db
Remove copy constraint for misallighment
darth-cy 80383f8
Change copy constraints to lookups
darth-cy 6198ea4
Remove debug flags
darth-cy 92b088d
Remove unnecessary return
darth-cy 1c12b9a
fmt
darth-cy 440916e
fmt
darth-cy 8131127
Correct documentation
darth-cy 23617f7
fmt
darth-cy ed2cd92
Merge remote-tracking branch 'scroll/feat/4844-chunk' into feat/blob-…
kunxian-xia fa565c0
Merge remote-tracking branch 'scroll/feat/4844-chunk-pi' into feat/bl…
kunxian-xia ada4e56
Feat/4844 Add Missing Chunk Parts (#1154)
darth-cy 99c22fa
fix
kunxian-xia 9d55e06
Fix: assign z_digest using load_u256 method (#1155)
kunxian-xia 40a8848
Fix bugs in integration test (#1160)
kunxian-xia 303475b
put reth-primitives at dev-dependency (#1166)
kunxian-xia 75572e0
bump c-kzg from 0.4.2 to 1.0.0
kunxian-xia cef667c
Update v2.0.7-patch-tungstenite for ethers utility
darth-cy cd4c57a
Merge branch 'develop' into feat/blob-4844-da-cargo-resolve
darth-cy 7203542
Resolve new cargo
darth-cy d6421ae
Update | Fix | Refactor | Unit Tests (#1167)
roynalnaruto 5d1f3ac
Merge remote-tracking branch 'scroll/feat/blob-4844-da-cargo-resolve'…
lispc eca92a3
Merge remote-tracking branch 'scroll/develop' into feat/blob-4844-da
lispc 726d84f
Merge remote-tracking branch 'scroll/develop' into feat/blob-4844-da
lispc b2205ec
clean deps
lispc 41cb87e
clean deps: revm
lispc bef05a7
remove reth dep
lispc ed36ea4
revert COINBASE changes
lispc 8782cd0
refactor: changes based on review of PR#1167 (#1172)
roynalnaruto abc57a5
big arrays replaced by vec and passed by ref (#1178)
roynalnaruto ab526a2
Check that chunk_idx increases on boundaries (#1173)
z2trillion df3a608
hash selector should only exist for digest rlc section | minor refact…
roynalnaruto b2fa4eb
Refactor and Optimise (#1179)
roynalnaruto b9504c0
pick fixes for testing...
lispc b2962cf
Fix copy duplicated comments (#1183)
z2trillion 7bca88d
tmp
lispc 0601c2d
Merge branch 'feat/blob-4844-da' of github.com:scroll-tech/zkevm-circ…
lispc 6046b40
Feat/Blob 4844 Chunk-level Patch (#1180)
darth-cy 74f2d8f
Feat/Blob 4844 Chunk-level TxCircuit CCC (#1188)
darth-cy dc64e09
better chunk proof marsha;
lispc b0a0d8a
Merge branch 'feat/blob-4844-da' of github.com:scroll-tech/zkevm-circ…
lispc 32d3c9d
chunk-prover: check proof after generated
lispc c2dc1f7
log vk commit
lispc 39742b1
improve prover verification
lispc 90bb8f2
Refactor | Clippy (#1187)
roynalnaruto 24044d4
fix q_step_first in evm circuit
lispc d60459e
Merge branch 'feat/blob-4844-da' of github.com:scroll-tech/zkevm-circ…
lispc 8d18161
Feat/Blob 4844 PICircuit Chunk TxBytes Condense (#1189)
darth-cy 4ff5305
fix rand table
lispc 35aab2e
Merge branch 'feat/blob-4844-da' of github.com:scroll-tech/zkevm-circ…
lispc 653f432
better log
lispc 5277a7b
fix halo2 vk
lispc 1540815
Merge branch 'develop' into feat/blob-4844-da
roynalnaruto 1ba3af0
add more logs for batch info
lispc 2f5a382
export BatchHash for testing purpose
kunxian-xia 6e2f321
add blob_assignments method
kunxian-xia 094450f
[FIX] big-endianness for blob poly from bytes (#1191)
roynalnaruto 15cfd66
Add missing PI bytes component (#1192)
darth-cy 85b79e5
Add more tests for BlobData struct (#1194)
z2trillion f75cd22
Rename N_BYTES_31 and N_BYTES_32 (#1193)
z2trillion 837544f
Fix/Remove Individual L2 TxHash from Keccak (#1197)
darth-cy 4f5c3bb
include selectors from blob data config (#1200)
roynalnaruto 055a1f0
Add feature `strict-ccc` for precheck panic. (#1003)
silathdiir 1bfef6a
include selectors from blob data config (#1200)
roynalnaruto 596d9c1
Merge branch 'feat/blob-4844-da' of github.com:scroll-tech/zkevm-circ…
lispc 5ff50fb
Merge branch 'v0.10' into feat/blob-4844-da
lispc cdb8346
optimize follower ccc
lispc 30b6c86
Merge remote-tracking branch 'scroll/develop' into feat/blob-4844-da
lispc 632a790
fix ccc post processing
lispc 842d0c1
disable default mode ci
lispc e1cad6f
fix k256 sig verify: normalize sig
lispc 8e7e644
lint
lispc bcba50d
Merge branch 'develop' into feat/blob-4844-da
lispc d47fa45
Merge branch 'develop' into feat/blob-4844-da
lispc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.