This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Bus-mapping for opcode calldatacopy#102
Closed
silathdiir wants to merge 28 commits into
Closed
Conversation
|
current status looks good to me. need to fix errors/conflicts introduced by recent merging |
silathdiir
changed the title
calldatacopy
icemelon
reviewed
Mar 11, 2022
Member
icemelon
left a comment
icemelon
left a comment
There was a problem hiding this comment.
after some further thoughts, I think we should leave the handling of calldatacopy for internal calls after the call PR privacy-ethereum#278 (busmapping included as well) is merged. The things we are adding in addition here are all temporary solutions and will be soon removed after call is supported.
DreamWuGit
reviewed
Mar 14, 2022
DreamWuGit
reviewed
Mar 14, 2022
2. Remove gas calculation and set in `calldatacopy` bus-mapping. 3. Revert `test_ok_internal` since not want to set internal call.
icemelon
force-pushed
the
calldatacopy-bus-mapping
branch
from
f5bdad6 to
58916b1
Compare
icemelon
reviewed
Mar 16, 2022
silathdiir
force-pushed
the
calldatacopy-bus-mapping
branch
from
7af2ca9 to
7e8716c
Compare
icemelon
approved these changes
Mar 17, 2022
Author
|
moved to privacy-ethereum#393 |
Member
|
close and move to privacy-ethereum#393 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associates issue privacy-ethereum#309
Only for code review, will implement
calldatacopybus-mapping on this branch to test if it is right as privacy-ethereum#309 (comment)