Skip to content

Conversation

@zimpha
Copy link
Member

@zimpha zimpha commented Jun 12, 2024

Purpose or design rationale of this PR

We have 7D timelock to update a new verifier in MultipleVersionRollupVerifier and it is hard to predict lastFinalizedBatchIndex by that time. We shall remove the check to make verifier upgrading more smoothly.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha requested review from Thegaram and spilehchiha June 12, 2024 08:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.31%. Comparing base (c65cdfc) to head (14f86d4).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1372   +/-   ##
========================================
  Coverage    54.31%   54.31%           
========================================
  Files          156      156           
  Lines        11922    11918    -4     
========================================
- Hits          6475     6473    -2     
+ Misses        4952     4950    -2     
  Partials       495      495           
Flag Coverage Δ
contracts 56.71% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimpha zimpha merged commit b0242c2 into develop Jun 12, 2024
@zimpha zimpha deleted the feat/remove_startBatchIndex_check branch June 12, 2024 09:05
zimpha added a commit to scroll-tech/scroll-contracts that referenced this pull request Jun 24, 2024
zimpha added a commit to scroll-tech/scroll-contracts that referenced this pull request Jun 24, 2024
sm4rtdev added a commit to sm4rtdev/scroll-contract that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants