Skip to content

refactor: duplicate functions into a single implementation #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdqst wants to merge 2 commits into from
Closed

refactor: duplicate functions into a single implementation #100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
823ed9d
refactor: duplicate functions into a single implementation
mdqst Apr 21, 2025
19cd7db
Update ScrollChainMockBlob.sol
mdqst Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/mocks/ScrollChainMockBlob.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ contract ScrollChainMockBlob is ScrollChain {
address _messageQueueV2,
address _verifier,
address _system
) ScrollChain(_chainId, _messageQueueV1, _messageQueueV2, _verifier, address(_system)) {}
) ScrollChain(_chainId, _messageQueueV1, _messageQueueV2, _verifier, _system) {}

/**********************
* Internal Functions *
Expand Down Expand Up @@ -48,10 +48,6 @@ contract ScrollChainMockBlob is ScrollChain {
overrideBatchHashCheck = status;
}

function _getBlobVersionedHash() internal virtual override returns (bytes32 _blobVersionedHash) {
_blobVersionedHash = blobhashes[0];
}

function _getBlobVersionedHash(uint256 index) internal virtual override returns (bytes32 _blobVersionedHash) {
_blobVersionedHash = blobhashes[index];
}
Expand Down