Skip to content

Conversation

@noel2004
Copy link
Member

Make the decompressor circuit support data generated from zstd lib without any hacking

@noel2004
Copy link
Member Author

noel2004 commented Mar 31, 2025

Following new fse header mode has been tested:

  • RLE mode
  • Repeated mode

@noel2004 noel2004 marked this pull request as ready for review March 31, 2025 12:02
@noel2004 noel2004 requested a review from roynalnaruto April 4, 2025 12:10
@noel2004
Copy link
Member Author

noel2004 commented Apr 4, 2025

Passed tests with recent 100 batches as examples

anyhow = "1"
serde = { version = "1", default-features = false, features = ["derive"] }
zstd-encoder = { package = "encoder", git = "https://github.com/scroll-tech/da-codec.git", tag = "v0.1.2", optional = true }
zstd-encoder = { package = "encoder", git = "https://github.com/scroll-tech/da-codec.git", branch = "test/prim_zstd", optional = true }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still Need this branch?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK It is a dev dep actually

Copy link
Collaborator

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question left

@lispc lispc merged commit 74f5227 into master Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants