Skip to content

Ceno-Compatible Recursion Leaf Nodes Adjustments #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feat/native_sumcheck_layer_eval
Choose a base branch
from
Open

Ceno-Compatible Recursion Leaf Nodes Adjustments #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caec16a
Examine AIR structure debug
darth-cy Oct 27, 2025
74b05d8
Adjust internal program
darth-cy Nov 9, 2025
8590149
Adjust checks
darth-cy Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion crates/continuations/src/verifier/common/non_leaf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,14 @@ impl<C: Config> NonLeafVerifierVariables<C> {
builder.range(0, proofs.len()).for_each(|i_vec, builder| {
let i = i_vec[0];
let proof = builder.get(proofs, i);

/* _debug
assert_required_air_for_agg_vm_present(builder, &proof);
let proof_vm_pvs = self.verify_internal_or_leaf_verifier_proof(builder, &proof);
*/

let proof_vm_pvs = self.verify_internal_or_leaf_verifier_proof(builder, &proof);
assert_single_segment_vm_exit_successfully(builder, &proof);

builder.if_eq(i, RVar::zero()).then_or_else(
|builder| {
builder.assign(&pvs.app_commit, proof_vm_pvs.vm_verifier_pvs.app_commit);
Expand All @@ -69,6 +73,8 @@ impl<C: Config> NonLeafVerifierVariables<C> {
);
},
);

/* _debug
Copy link

@kunxian-xia kunxian-xia Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why comment these out?

assert_or_assign_connector_pvs(
builder,
&pvs.connector,
Expand All @@ -81,13 +87,17 @@ impl<C: Config> NonLeafVerifierVariables<C> {
i,
&proof_vm_pvs.vm_verifier_pvs.memory,
);
*/

// This is only needed when `is_terminate` but branching here won't save much, so we
// always assign it.
builder.assign(
&pvs.public_values_commit,
proof_vm_pvs.vm_verifier_pvs.public_values_commit,
);
});


(pvs, leaf_verifier_commit)
}
fn verify_internal_or_leaf_verifier_proof(
Expand Down Expand Up @@ -132,6 +142,7 @@ impl<C: Config> NonLeafVerifierVariables<C> {
&self.leaf_advice,
proof,
);

// Leaf verifier doesn't have extra public values.
assign_array_to_slice(
builder,
Expand Down
2 changes: 2 additions & 0 deletions crates/sdk/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ impl<E: StarkFriEngine<SC>> GenericSdk<E> {
let exe_commit_bn254 = app_commit.app_exe_commit.to_bn254();
let vm_commit_bn254 = app_commit.app_vm_commit.to_bn254();

/* _debug: execution commit checks
if exe_commit_bn254 != *expected_exe_commit {
return Err(eyre::eyre!(
"Invalid app exe commit: expected {:?}, got {:?}",
Expand All @@ -426,6 +427,7 @@ impl<E: StarkFriEngine<SC>> GenericSdk<E> {
vm_commit_bn254
));
}
*/
Ok(app_commit)
}

Expand Down
Loading