Skip to content

[sync] upstream inverse acceleration#10

Merged
lispc merged 3 commits into
v0.1.0from
upstream-inverse-acc
Aug 17, 2024
Merged

[sync] upstream inverse acceleration#10
lispc merged 3 commits into
v0.1.0from
upstream-inverse-acc

Conversation

@Velaciela

Copy link
Copy Markdown

Description:

From snarkify merkle circuit example (comparison),
we find that the performance of the poseidon hash in the Scroll version has a gap compared to the upstream.

And it turns out that the inverse() operation is the main bottleneck.

related PR

This PR cherry-picked several performance-optimizing PRs from upstream:

performance

before

Start: kzg k_table_size=18 repeat_count=10
··Start: keygen
··End: keygen............................................................175.00s
··Start: prove
··End: prove.............................................................106.00s
··Start: verify
··End: verify..............................................................0.01s
End: kzg k_table_size=18 repeat_count=10.................................290.00s

after

Start: kzg k_table_size=18 repeat_count=10
··Start: keygen
··End: keygen.............................................................40.40s
··Start: prove
··End: prove..............................................................38.80s
··Start: verify
··End: verify..............................................................0.01s
End: kzg k_table_size=18 repeat_count=10..................................89.10s

mratsim and others added 3 commits August 14, 2024 09:20
* Bernstein yang modular multiplicative inverter (#2)

* rename similar to privacy-ethereum#95

---------

Co-authored-by: Aleksei Vambol <77882392+AlekseiVambol@users.noreply.github.com>
…rivacy-ethereum#95)

* Derivatives of the Pornin's method (taikoxyz#3)

* renaming file

* make cargo fmt happy

* clarifications from privacy-ethereum#95 (comment) [skip ci]

* Formatting and slightly changing a comment

---------

Co-authored-by: Aleksei Vambol <77882392+AlekseiVambol@users.noreply.github.com>
@lispc lispc changed the base branch from use_pairing to v0.1.0 August 17, 2024 12:14
@lispc lispc merged commit a495a7b into v0.1.0 Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants