Skip to content

remove multiphase mock prover

Sign in for the full log view
GitHub Actions / Clippy (beta) failed Dec 13, 2023 in 0s

Clippy (beta)

7 errors, 9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 7
Warning 9
Note 0
Help 0

Versions

  • rustc 1.66.0 (69f9c33d7 2022-12-12)
  • cargo 1.66.0 (d65d197ad 2022-11-15)
  • clippy 0.1.66 (69f9c33 2022-12-12)

Annotations

Check failure on line 1117 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope 

error[E0599]: no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope
    --> halo2_proofs/src/dev.rs:1117:28
     |
1117 |         prover.permutation.build_ordered_mapping();
     |                            ^^^^^^^^^^^^^^^^^^^^^ method not found in `std::option::Option<plonk::permutation::keygen::Assembly>`
     |
note: the method `build_ordered_mapping` exists on the type `plonk::permutation::keygen::Assembly`
    --> halo2_proofs/src/plonk/permutation/keygen.rs:260:5
     |
260  |     pub fn build_ordered_mapping(&mut self) {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: consider using `Option::expect` to unwrap the `plonk::permutation::keygen::Assembly` value, panicking if the value is an `Option::None`
     |
1117 |         prover.permutation.expect("REASON").build_ordered_mapping();
     |                           +++++++++++++++++

Check failure on line 1091 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `F: group::Group` is not satisfied 

error[E0277]: the trait bound `F: group::Group` is not satisfied
    --> halo2_proofs/src/dev.rs:1091:17
     |
1090 |             batch_invert_cellvalues(
     |             ----------------------- required by a bound introduced by this call
1091 |                 Arc::get_mut(&mut prover.fixed_vec).expect("get_mut prover.fixed_vec"),
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `group::Group` is not implemented for `F`
     |
note: required by a bound in `dev::batch_invert_cellvalues`
    --> halo2_proofs/src/dev.rs:178:39
     |
178  | fn batch_invert_cellvalues<F: Field + Group>(cell_values: &mut [Vec<CellValue<F>>]) {
     |                                       ^^^^^ required by this bound in `dev::batch_invert_cellvalues`
help: consider further restricting this bound
     |
900  | impl<'a, F: FromUniformBytes<64> + Ord + group::Group> MockProver<'a, F> {
     |                                        ++++++++++++++

Check failure on line 1088 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `F: group::Group` is not satisfied 

error[E0277]: the trait bound `F: group::Group` is not satisfied
    --> halo2_proofs/src/dev.rs:1088:17
     |
1087 |             batch_invert_cellvalues(
     |             ----------------------- required by a bound introduced by this call
1088 |                 Arc::get_mut(&mut prover.advice_vec).expect("get_mut prover.advice_vec"),
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `group::Group` is not implemented for `F`
     |
note: required by a bound in `dev::batch_invert_cellvalues`
    --> halo2_proofs/src/dev.rs:178:39
     |
178  | fn batch_invert_cellvalues<F: Field + Group>(cell_values: &mut [Vec<CellValue<F>>]) {
     |                                       ^^^^^ required by this bound in `dev::batch_invert_cellvalues`
help: consider further restricting this bound
     |
900  | impl<'a, F: FromUniformBytes<64> + Ord + group::Group> MockProver<'a, F> {
     |                                        ++++++++++++++

Check failure on line 824 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `F: group::Group` is not satisfied 

error[E0277]: the trait bound `F: group::Group` is not satisfied
   --> halo2_proofs/src/dev.rs:824:42
    |
824 |             *assigned? = CellValue::from(to().into_field().assign()?);
    |                          --------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `group::Group` is not implemented for `F`
    |                          |
    |                          required by a bound introduced by this call
    |
note: required for `dev::CellValue<F>` to implement `std::convert::From<plonk::assigned::Assigned<F>>`
   --> halo2_proofs/src/dev.rs:149:24
    |
149 | impl<F: Group + Field> From<Assigned<F>> for CellValue<F> {
    |                        ^^^^^^^^^^^^^^^^^     ^^^^^^^^^^^^
help: consider further restricting this bound
    |
481 | impl<'a, F: Field + group::Group> Assignment<F> for MockProver<'a, F> {
    |                   ++++++++++++++

Check failure on line 746 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the trait bound `F: group::Group` is not satisfied 

error[E0277]: the trait bound `F: group::Group` is not satisfied
   --> halo2_proofs/src/dev.rs:746:40
    |
746 |         let assigned = CellValue::from(val_res?);
    |                        --------------- ^^^^^^^^ the trait `group::Group` is not implemented for `F`
    |                        |
    |                        required by a bound introduced by this call
    |
note: required for `dev::CellValue<F>` to implement `std::convert::From<plonk::assigned::Assigned<F>>`
   --> halo2_proofs/src/dev.rs:149:24
    |
149 | impl<F: Group + Field> From<Assigned<F>> for CellValue<F> {
    |                        ^^^^^^^^^^^^^^^^^     ^^^^^^^^^^^^
help: consider further restricting this bound
    |
481 | impl<'a, F: Field + group::Group> Assignment<F> for MockProver<'a, F> {
    |                   ++++++++++++++

Check warning on line 3 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `Field` 

warning: unused import: `Field`
 --> halo2_proofs/src/helpers.rs:3:10
  |
3 | use ff::{Field, FromUniformBytes, PrimeField};
  |          ^^^^^

Check warning on line 52 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `crate::circuit::Cell` 

warning: unused import: `crate::circuit::Cell`
  --> halo2_proofs/src/dev.rs:52:5
   |
52 | use crate::circuit::Cell;
   |     ^^^^^^^^^^^^^^^^^^^^

Check warning on line 22 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `Phase` 

warning: unused import: `Phase`
  --> halo2_proofs/src/dev.rs:22:64
   |
22 |         Expression, FirstPhase, Fixed, FloorPlanner, Instance, Phase, Selector,
   |                                                                ^^^^^

Check warning on line 8 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused imports: `Duration`, `Instant` 

warning: unused imports: `Duration`, `Instant`
 --> halo2_proofs/src/dev.rs:8:17
  |
8 | use std::time::{Duration, Instant};
  |                 ^^^^^^^^  ^^^^^^^

Check warning on line 5 in halo2_proofs/src/transcript/poseidon.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `num_bigint::BigUint` 

warning: unused import: `num_bigint::BigUint`
 --> halo2_proofs/src/transcript/poseidon.rs:5:5
  |
5 | use num_bigint::BigUint;
  |     ^^^^^^^^^^^^^^^^^^^

Check warning on line 1 in halo2_proofs/src/plonk/vanishing/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `collections::HashMap` 

warning: unused import: `collections::HashMap`
 --> halo2_proofs/src/plonk/vanishing/prover.rs:1:11
  |
1 | use std::{collections::HashMap, iter};
  |           ^^^^^^^^^^^^^^^^^^^^

Check warning on line 19 in halo2_proofs/src/circuit/floor_planner/single_pass.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `multicore` 

warning: unused import: `multicore`
  --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:19:5
   |
19 |     multicore,
   |     ^^^^^^^^^

Check warning on line 6 in halo2_proofs/src/circuit/floor_planner/single_pass.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused imports: `Arc`, `Mutex` 

warning: unused imports: `Arc`, `Mutex`
 --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:6:17
  |
6 | use std::sync::{Arc, Mutex};
  |                 ^^^  ^^^^^

Check warning on line 5 in halo2_proofs/src/circuit/floor_planner/single_pass.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `std::ops::Range` 

warning: unused import: `std::ops::Range`
 --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:5:5
  |
5 | use std::ops::Range;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check failure on line 223 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

failed to resolve: use of undeclared crate or module `rayon` 

error[E0433]: failed to resolve: use of undeclared crate or module `rayon`
   --> halo2_proofs/src/dev.rs:223:5
    |
223 |     rayon::scope(|scope| {
    |     ^^^^^ use of undeclared crate or module `rayon`

Check failure on line 208 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

failed to resolve: use of undeclared crate or module `rayon` 

error[E0433]: failed to resolve: use of undeclared crate or module `rayon`
   --> halo2_proofs/src/dev.rs:208:23
    |
208 |     let num_threads = rayon::current_num_threads();
    |                       ^^^^^ use of undeclared crate or module `rayon`
View more details on GitHub Actions