use par invert

scroll-tech · Nov 15, 2023 · ee957d8 · ee957d8
1 parent e837827
commit ee957d8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/halo2_proofs/src/arithmetic.rs b/halo2_proofs/src/arithmetic.rs
@@ -532,6 +532,12 @@ where
     q
 }
 
+pub fn par_invert<F: Field>(values: &mut [F]) {
+    parallelize(values, |values, _start| {
+        values.batch_invert();
+    });
+}
+
 /// This simple utility function will parallelize an operation that is to be
 /// performed over a mutable slice.
 pub(crate) fn parallelize_internal<T: Send, F: Fn(&mut [T], usize) + Send + Sync + Clone>(

diff --git a/halo2_proofs/src/plonk/mv_lookup/prover.rs b/halo2_proofs/src/plonk/mv_lookup/prover.rs
@@ -31,7 +31,7 @@ use std::{
     ops::{Mul, MulAssign},
 };
 
-use crate::arithmetic::parallelize_internal;
+use crate::arithmetic::{par_invert, parallelize_internal};
 use rayon::prelude::{IndexedParallelIterator, IntoParallelRefIterator, ParallelIterator};
 
 #[derive(Debug)]
@@ -256,8 +256,7 @@ impl<C: CurveAffine> Prepared<C> {
                 },
             );
             let inputs_inv_time = start_timer!(|| "batch invert");
-            // TODO: use parallelized batch invert
-            input_log_derivatives.iter_mut().batch_invert();
+            par_invert(input_log_derivatives.as_mut_slice());
             end_timer!(inputs_inv_time);
 
             // TODO: remove last blinders from this
@@ -283,8 +282,7 @@ impl<C: CurveAffine> Prepared<C> {
         );
 
         let table_inv_time = start_timer!(|| "table batch invert");
-        // TODO: use parallelized batch invert
-        table_log_derivatives.iter_mut().batch_invert();
+        par_invert(table_log_derivatives.as_mut_slice());
         end_timer!(table_inv_time);
         end_timer!(table_log_drv_time);