halo2-ecc: fix ecc_double for p256#31
Merged
Merged
Conversation
DreamWuGit
changed the title
Author
|
Note: does this method name changes for more generic parameter influence others repo which depends on halo2-ecc like snark-verifier ? zkevm-circuit i will update once this pr merged in sig circuit pr. |
Author
tested in snark verifier PR scroll-tech/snark-verifier#38 |
lispc
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue #29
make relating helpers with CurveAffine generic parameter and include missing
aparameter in ecc_double method