fix: remove wrong transition check in rollup-verifier

[Thegaram]

1. Purpose or design rationale of this PR

This transition check was supposed to initialize prevL1MessageQueueHash in EuclidV2, but it also got applied in Feynman, erroneously resetting the msg queue hash to zero, halting the rollup verification process.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling during rollup synchronization by dynamically resetting sync height based on specific error conditions.
  • Added support for an additional error condition that triggers a sync reset to a new block height.

• Chores

  • Updated patch version number.

[coderabbitai]

Walkthrough

The patch increments the VersionPatch constant in the versioning parameters and refactors error handling in the rollup sync service by replacing a sentinel error with a typed error carrying a reset height. It adds a new reset condition, updates error detection to use errors.As, and simplifies previous L1 message queue hash assignment by removing a codec version check.

Changes

Files	Change Summary
params/version.go	Incremented VersionPatch constant from 73 to 74.
rollup/rollup_sync_service/rollup_sync_service.go	Replaced sentinel error with typed error carrying reset height; updated error handling to use errors.As; added new reset condition; simplified previous L1 message queue hash assignment by removing codec version check.

Sequence Diagram(s)

sequenceDiagram
    participant RollupSyncService
    participant ErrorType
    participant SyncState

    RollupSyncService->>ErrorType: Detect error with errors.As
    ErrorType->>RollupSyncService: Provide reset height
    RollupSyncService->>SyncState: SetL1Height(reset height)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix(verifier,l1follower): update da-codec to latest version #1143: Introduces sentinel error and version patch increment in rollup_sync_service.go and params/version.go, overlapping with error handling and version bump changes here.
• fix(rollup verifier): nil pointer due to missing CommittedBatchMeta #1188: Also modifies rollup_sync_service.go error handling and version patch, adding rewind logic for batch metadata errors, related to sync recovery strategies.
• feat(L1 follower and rollup verifier): support CodecV7 in L1 follower mode and rollup verifier #1105: Updates batch metadata handling and versioning in rollup_sync_service.go, related to the simplified previous L1 message queue hash assignment in this PR.

Suggested labels

bump-version

Suggested reviewers

• colinlyguo

Poem

🐇 A patch hops up, from seventy-three to four,
Errors now carry heights, resetting sync’s core.
No more sentinel guesses, just typed clarity,
The rollup’s in sync, with new verity.
Hash checks simplified, the path is bright—
CodeRabbit’s leap, swift and light! ✨🐰

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a93910 and 15298ae.

📒 Files selected for processing (1)

• rollup/rollup_sync_service/rollup_sync_service.go (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: test
• GitHub Check: check
• GitHub Check: Analyze (go)

🔇 Additional comments (4)

rollup/rollup_sync_service/rollup_sync_service.go (4)

55-61: LGTM! Excellent improvement in error handling design.

The transition from sentinel error to typed error with embedded context (height) is a best practice that makes the code more maintainable and type-safe. The Error() method provides clear formatting.

---

234-238: LGTM! Proper implementation of typed error handling.

The use of errors.As with type assertion is the correct Go idiom for handling typed errors. The dynamic height extraction from the error makes the reset logic more flexible and eliminates hardcoded values.

---

492-493: LGTM! Fixes the core issue described in the PR.

This change removes the erroneous transition check that was causing the message queue hash to reset to zero. The unconditional assignment with the clear comment about the empty hash assumption for the first CodecV7 batch is the correct approach.

---

601-613: LGTM! Comprehensive handling of known hash mismatch issues.

The implementation correctly addresses both the EuclidV2 and Feynman upgrade issues with:

• Specific hash value detection for precise error identification
• Clear warning logs explaining each issue
• Consistent use of the new typed error pattern
• Appropriate reset heights for each scenario

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-remove-wrong-transition-check-in-rollup-verifier

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.