feat: update L2 base fee formula

[yiweichi]

1. Purpose or design rationale of this PR

Update L2 base fee according to new cost estimates.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
• ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
• docs: Documentation-only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes

  • Reduced proving and verification fees, lowering overall base fee calculations.
  • Updated test cases to align with revised base fee values and error message details.

• Chores

  • Incremented the patch version from 38 to 39.
  • Updated GitHub Actions workflow to use Ubuntu 22.04 environment.

[coderabbitai]

Walkthrough

The changes update the calculation parameters for the L2 base fee in the consensus logic, specifically lowering the proving and verification fee contributions. Corresponding test cases are updated to reflect the new fee calculation logic. Additionally, two transaction hash expectations in state processor error tests are updated, the GitHub Actions Semgrep workflow runner environment is upgraded from Ubuntu 20.04 to 22.04, and the patch version number is incremented from 38 to 39 in the versioning parameters. No public function signatures or exported entity interfaces are changed.

Changes

File(s)	Summary
consensus/misc/eip1559.go	Adjusted constants in CalcBaseFee to lower the proving and verification fee contributions.
consensus/misc/eip1559_test.go	Updated test cases in TestCalcBaseFee to match new L2 base fee calculation logic.
core/state_processor_test.go	Updated expected transaction hashes in two error case tests.
params/version.go	Incremented VersionPatch constant from 38 to 39.
.github/workflows/semgrep.yml	Updated GitHub Actions runner environment from ubuntu-20.04 to ubuntu-22.04.

Sequence Diagram(s)

sequenceDiagram
    participant ParentL1 as Parent L1 Base Fee
    participant CalcBaseFee as CalcBaseFee Function
    participant Output as L2 Base Fee

    ParentL1->>CalcBaseFee: Provide L1 base fee
    CalcBaseFee->>CalcBaseFee: Apply new provingFee and verificationFee constants
    CalcBaseFee->>CalcBaseFee: Add sequencer fee, cap at MaximumL2BaseFee
    CalcBaseFee-->>Output: Return computed L2 base fee

Loading

Suggested reviewers

• roylou
• omerfirmak

Poem

Hopping through code with a whisk and a fee,
Constants now lighter—less weight for L2 to be!
Tests get a polish, hashes anew,
Version hops forward, from 38 to 39 too.
With every byte, a gentler hop,
This rabbit’s work is never a stop!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1496631 and 3916abe.

📒 Files selected for processing (3)

• consensus/misc/eip1559.go (1 hunks)
• consensus/misc/eip1559_test.go (1 hunks)
• core/state_processor_test.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• consensus/misc/eip1559_test.go
• core/state_processor_test.go
• consensus/misc/eip1559.go

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test
• GitHub Check: Analyze (go)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[roylou]

@yiweichi Can you also adjust DA fee related parameters? I don't see it being updated.
Base fee offset and multiplier are good.

Also Do you mind adjusting bundle timeout to 11 hrs at the same time? See https://scrollco.slack.com/archives/C06UP3R13MW/p1744930917421349?thread_ts=1744417193.866009&cid=C06UP3R13MW

[yiweichi]

@yiweichi Can you also adjust DA fee related parameters? I don't see it being updated.

Base fee offset and multiplier are good.

Also Do you mind adjusting bundle timeout to 11 hrs at the same time? See https://scrollco.slack.com/archives/C06UP3R13MW/p1744930917421349?thread_ts=1744417193.866009&cid=C06UP3R13MW

To update DA fee will need Xi to interact with contract, Colin already reached out to him.
Sure I can adjust the bundle timeout.