Skip to content

Fix: rolling hash implementation #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonastheis merged 4 commits into from
Feb 14, 2025
Merged

Fix: rolling hash implementation #42

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3fcbce
fix: clear 32 bits instead of 36
roynalnaruto Feb 13, 2025
b6d1049
fix: test expectations for rolling hash
roynalnaruto Feb 14, 2025
44f4261
fix: tests
roynalnaruto Feb 14, 2025
26dc8d5
fix tests
jonastheis Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions encoding/da.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,12 +815,7 @@ func messageQueueV2ApplyL1Message(initialQueueHash common.Hash, message *types.L
}

func messageQueueV2EncodeRollingHash(rollingHash common.Hash) common.Hash {
// clear last 36 bits

// Clear the lower 4 bits of byte 26 (preserving the upper 4 bits)
rollingHash[27] &= 0xF0

// Clear the next 4 bytes (32 bits total)
// clear last 32 bits, i.e. 4 bytes.
rollingHash[28] = 0
rollingHash[29] = 0
rollingHash[30] = 0
Expand Down
Loading