Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility of switching modes without killing sound #24

Open
rblard opened this issue Oct 31, 2023 · 1 comment
Open

Add possibility of switching modes without killing sound #24

rblard opened this issue Oct 31, 2023 · 1 comment

Comments

@rblard
Copy link
Collaborator

rblard commented Oct 31, 2023

In the web-app, it is now possible to shift modes freely at the press of a button. However, because this requires setting the index, and because setting the index executes the note events callback with an all-notes-off vector, this means that the transition is never quite fluid.

Potentially, this calls for the need to either :
A. Set the index without stopping, or
B. Stop without killing sound

Either of which could introduce bugs in other contexts.

@josephlarralde
Copy link
Contributor

This issue plus some discussions we had before about your mode shift implementation seem to indicate that there is something clunky about this part of the library's API, and that it might need to be rethinked a bit (and while we're at it, this could also be an opportunity to add the MIDI track information to the event sets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants