Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization update #471

Merged
merged 6 commits into from
Jun 22, 2024
Merged

Conversation

Jag-Marcel
Copy link
Collaborator

Contributor checklist


Description

Updated localization with the new keys from i18n, added localization for the TipCardView and simplified some code.

617633f Update i18n keys to include app and _global top level keys - fix install.text
61dfc5a Merge pull request scribe-org#19 from weblate/weblate-scribe-scribe-i18n
a7fd2bd Translated using Weblate (German)
ea318e1 Translated using Weblate (English (United States))
27e392e Translated using Weblate (German)
36f8641 Translated using Weblate (English (United States))
671614d Minor HTML formatting for readme code

git-subtree-dir: Scribe/i18n
git-subtree-split: 617633f8c6f1d8fbaf3829b77586107f60fd9425
13a4d74 Update scripts with print output + usage examples + convert to xcstrings
333ecc7 Merge pull request scribe-org#21 from Jag-Marcel/conversion-script-fix
8166196 Update i18n key to be installation, not install
64ba128 Fixed script to accommodate missing key in l10n files

git-subtree-dir: Scribe/i18n
git-subtree-split: 13a4d748b4b75c3a0e5b32ea3db5b0abb4a0cc82
Copy link

github-actions bot commented Jun 22, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review June 22, 2024 18:25
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks perfect, @Jag-Marcel! Officially ready from the localization side of things for v3.1! Looking forward to getting it out :) :)

@andrewtavis andrewtavis merged commit 3fc481e into scribe-org:main Jun 22, 2024
2 checks passed
@Jag-Marcel Jag-Marcel deleted the localization-update branch June 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants