Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert i18n over to a JSON directory #392

Closed
2 of 5 tasks
andrewtavis opened this issue Jan 13, 2024 · 5 comments
Closed
2 of 5 tasks

Convert i18n over to a JSON directory #392

andrewtavis opened this issue Jan 13, 2024 · 5 comments
Assignees
Labels
-next release- Included in the next release feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jan 13, 2024

Terms

Description

Something that Scribe-iOS will need to implement for a common localization process with Scribe-Android is to have a common JSON directory that has all of the localized strings that are needed for the app. This directory would then be controlled by Scribe-i18n in a way that changes to i18n would then trigger PRs in Scribe-iOS and Scribe-Android (and any other repos). We'll need a base en-US.json file and then a file for any other language that we're localizing Scribe into 😊

We're choosing to stick with JSON to assure that localization tools like Transifex or weblate can be used for community localizations. We have some texts like the privacy policy that need formatting and thus their own .swift files, but for individual like menu option labels these can be stored within a common file. The general idea would be to save them in a JSON and then make use of SwiftyJSON to load them in and access the key-value pairs.

Parts to this issue:

  • See if there's a good extension for this that is well maintained
  • Set up Transifex/Weblate/TranslateWiki for Scribe
  • Explore commits from external source i18n software to i18n repo to this repo
    - [ ] Switch over string references in the menu to use JSON keys for localized strings
    • We'll have new issues for this :)

Contribution

Happy to discuss the implementation of this and work on it or support! The focus should be on first getting all the English texts into the system, and then we can move over to Scribe-i18n to start adding in new languages that will then be triggered when the user changes their system language.

@andrewtavis
Copy link
Member Author

@Jag-Marcel, can you write in here so I can assign? :)

@andrewtavis
Copy link
Member Author

We can get started on this once #415 is merged in 🚀

@Jag-Marcel
Copy link
Member

👍

@andrewtavis
Copy link
Member Author

Thanks @Jag-Marcel! ☀️☀️

@andrewtavis
Copy link
Member Author

Closed via #452 🥳 Thanks for all the work here, @Jag-Marcel! Great progress so far 👏👏

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-next release- Included in the next release feature New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants