-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert i18n over to a JSON directory #392
Labels
-next release-
Included in the next release
feature
New feature or request
help wanted
Extra attention is needed
Comments
This was referenced Apr 1, 2024
@Jag-Marcel, can you write in here so I can assign? :) |
We can get started on this once #415 is merged in 🚀 |
👍 |
Thanks @Jag-Marcel! ☀️☀️ |
Closed via #452 🥳 Thanks for all the work here, @Jag-Marcel! Great progress so far 👏👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-next release-
Included in the next release
feature
New feature or request
help wanted
Extra attention is needed
Terms
Description
Something that Scribe-iOS will need to implement for a common localization process with Scribe-Android is to have a common JSON directory that has all of the localized strings that are needed for the app. This directory would then be controlled by Scribe-i18n in a way that changes to i18n would then trigger PRs in Scribe-iOS and Scribe-Android (and any other repos). We'll need a base
en-US.json
file and then a file for any other language that we're localizing Scribe into 😊We're choosing to stick with JSON to assure that localization tools like Transifex or weblate can be used for community localizations. We have some texts like the privacy policy that need formatting and thus their own
.swift
files, but for individual like menu option labels these can be stored within a common file. The general idea would be to save them in a JSON and then make use of SwiftyJSON to load them in and access the key-value pairs.Parts to this issue:
- [ ] Switch over string references in the menu to use JSON keys for localized stringsContribution
Happy to discuss the implementation of this and work on it or support! The focus should be on first getting all the English texts into the system, and then we can move over to Scribe-i18n to start adding in new languages that will then be triggered when the user changes their system language.
The text was updated successfully, but these errors were encountered: