[Refactor] Improve code quality

[damien-rivet]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-iOS' Code of Conduct

Description

The whole codebase could benefit from a code quality upgrade.

A non-exhaustive list:

• Remove all instance of force-unwraps
• Replace usage of if something { let something } checks with guard let and if let whenever possible to allow for early return and nil-unwrapping safety
• Use isEmpty instead of .count
• Move hardcoded strings and magic numbers into dedicated constants (sizes, languages, keyboards, keys, icons, etc.)

Contribution

No response

[henrikth93]

I am interested in this one

[andrewtavis]

Thanks @henrikth93! Let me know if there's something I can do to support! 😊

[andrewtavis]

Via a call that @henrikth93 and I are having, we've decided that this can be done on a basis where changes can be sent for individual or smaller groups of files 😊

[LeTarrask]

@henrikth93, @andrewtavis, can I also have a shot in a few of those issues? maybe just small linting and replacing ifs for guard let, and stuff?

[andrewtavis]

Sounds good to me, @LeTarrask! Let's wait for @henrikth93 to confirm in case he's been working on them already :) Thanks for your interest in helping out!

[henrikth93]

@LeTarrask @andrewtavis My focus is on fixing magic numbers at the moments, so feel free Alex!

[andrewtavis]

Fantastic :) Let us know if you have any questions, @LeTarrask!

[jocoand]

Hello, I'm interested in working on this

I plan to do some .count replacement stuff, can I work on that?

[andrewtavis]

da23dd0 sent along tons of changes to address force unwraps, use if let/guard let more and also added in usages of isEmpty where possible (also d0e621e worked on isEmpty). The error handling of if let and guard let can definitely be improved, but I'd say that for this and any other parts that can be improved we can switch to individual issues :) Thanks all so much for the contributions here! Really is such an improvement, and I'm looking forward to where we go from here!

If anyone sees anything in da23dd0 or in the current codebase that should be worked on, please open an individual issue for it and we'll get to it when we can!