Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Disable accent characters for menus that it's not needed on #372

Closed
2 tasks done
andrewtavis opened this issue Oct 21, 2023 · 3 comments
Closed
2 tasks done

Remove Disable accent characters for menus that it's not needed on #372

andrewtavis opened this issue Oct 21, 2023 · 3 comments
Assignees
@henrikth93
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Behavior

In #339 we added an option to disable the accent characters of certain keyboards. Something that we need to do now is have this option show up in the settings only for those languages that it makes a change for: specifically German, Swedish and Spanish.

Would be great if someone wants to help with this! Happy to support or get to it soon 😊

Device type

iPhone and iPad

Versions

Current development branch
@andrewtavis andrewtavis added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Oct 21, 2023
@henrikth93
Copy link
Member

I am interested in this one

@andrewtavis
Copy link
Member Author

Thanks @henrikth93! Assigning you now :)

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Oct 21, 2023
henrikth93 added a commit to henrikth93/Scribe-iOS that referenced this issue Oct 25, 2023
@henrikth93
Merge branch 'henrikth93-scribe-org#372' of https://github.com/henrik…
efb84c1 
…th93/Scribe-iOS into henrikth93-scribe-org#372
andrewtavis added a commit that referenced this issue Nov 2, 2023
@andrewtavis
Merge pull request #375 from henrikth93/henrikth93-#372
f450a0a 
Remove Disable accent characters for menus that it's not needed on #372
andrewtavis added a commit that referenced this issue Nov 2, 2023
@andrewtavis
#372 code and comment formatting
d2e4c67
@andrewtavis
Copy link
Member Author

It took just a bit for the hack to really grow on me, @henrikth93 :) d2e4c67 sends along formatting for the code, but aside from that all's great. Makes sense to me. We want an index, we need a default in case it's not there, and we assign -1 so we don't need to deal with converting the type. Thanks for the work here and the great idea! 😊

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikth93 henrikth93

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @henrikth93