Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning and implementing a feature to change the app's language #120

Closed
2 tasks done
Tracked by #9
andrewtavis opened this issue Feb 3, 2022 · 4 comments
Closed
2 tasks done
Tracked by #9
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed localization Add or correct localizations

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Feb 3, 2022

Terms

Description

This issue is to make the Scribe app react to the system language that's present on a user's device, thus allowing for localization of the app screen. Once this is finished, work will begin on creating localizations for all languages that Scribe currently provides keyboards for.

Contribution

I'd be happy to work on this if others don't have interest :)

@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed localization Add or correct localizations labels Feb 3, 2022
@gitpushOmnik
Copy link
Contributor

Hey @andrewtavis, I would love to solve this issue. Can you please assign it to me?

@andrewtavis
Copy link
Member Author

Yes, @gitpushOmnik :) Would be a great issue to work on 😊 Assigning you now!

@andrewtavis
Copy link
Member Author

Hey @gitpushOmnik, answering your question from Matrix here :)

For issue #120, by changing the language of the app screen, do you mean changing the language of the privacy policy, keyboard installation and community texts according to the user's system set language? For example, if the system language was English, the text language of "privacy policy, keyboard installation and community" should be English and if the system language was German, the text language of "privacy policy, keyboard installation and community" should be German?

This is exactly what we're looking for in this issue. Within Scribe/AppTexts we'd then be able to make new folders like Spanish and German where we'd have versions of the privacy policy and the app texts in each of those languages. The texts for the button and headers would also change as you discussed :) We'd have the Privacy policy button be localized to the given language, and with that also the keyboard installation steps and the text within the community section 😊

The ideality here would be that the English app texts would be the default, which we should be able to do by just assigning blank strings for the languages we want to allow. For languages that aren't English we check first to see if the string is empty, and if it is we assign the English version, or if not we assign the translation that we've gotten from the community :)

@andrewtavis
Copy link
Member Author

Ok, @gitpushOmnik 😊 I think we're good to close this :) As I said in #266, let's hold off on adding new languages for now as the app will be going through an overhaul during GSoC. Nice to have two languages in there so that we have a basis to work from when we're adding more once the new designs are implemented.

Thanks so much for your help! Happy to have these contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed localization Add or correct localizations
Projects
Archived in project
Development

No branches or pull requests

2 participants