Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rollup-plugin-typescript2 to fix nodejs 17 #164

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

johntron
Copy link
Contributor

@johntron johntron commented May 8, 2022

Running npm run push-main gives this with nodejs 17:

Package subpath './package.json' is not defined by "exports" in /home/wouldntyouliketoknow/node_modules/tslib/package.json

This change incorporates the fix from rollup-plugin-typescript2 v0.31.0.

Please feel free to merge for me.

Running `npm run push-main` gives this with nodejs 17:

> Package subpath './package.json' is not defined by "exports" in /home/wouldntyouliketoknow/node_modules/tslib/package.json

This change incorporates [the fix](ezolenko/rollup-plugin-typescript2#286) from rollup-plugin-typescript2 v0.31.0.
Copy link

@sondrev sondrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that I had the same error message that you experienced, and bumping this version fixed it for me.

@pyrodogg
Copy link
Member

Thanks for the PR. I don't have time to test it but since @sondrev is indicating it works and also found the same, I'll merge it.

@pyrodogg pyrodogg merged commit 9f81797 into screepers:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants