Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid interface errors in generated XCFramework #4

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

nicoelayda
Copy link

This adds a script in the build_xcframework lane to handle a Swift compiler bug that generates a broken textual interface. See swiftlang/swift#56573 for details.

Implementation

Remove all YapDatabase.* prefix in all *.swiftinterface files.

Testing

  1. Build using bundle exec fastlane build_xcframework
  2. Add generated YapDatabase.xcframework to a new project and import YapDatabase in AppDelegate.swift.
  3. Compiles with no errors.

…tinterface files.

This is a workaround for a compiler bug that generates a broken textual interface. See swiftlang/swift#56573 for details.
@nicoelayda nicoelayda requested a review from hujunfeng August 30, 2022 09:09
Copy link
Member

@hujunfeng hujunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hujunfeng hujunfeng merged commit 5150e55 into master Aug 30, 2022
@hujunfeng hujunfeng deleted the fix/invalid-interface branch August 30, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants