Skip to content

Conversation

@MiroslavDionisiev
Copy link
Contributor

@MiroslavDionisiev MiroslavDionisiev commented Aug 26, 2024

Jira Ticket

UEPR-33

Proposed Changes

  • updated node version of scratch-editor
  • changed directory name from workspaces to packages
  • added @scracth organization prefix to imports

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I wonder how I missed the packages/* suggestion in the NPM docs. I'm pretty sure I started this after npm/cli#4426 but oh well :)

Anyway, one typo and I'd like to understand the need for the uninstall bit, but it seems pretty much 👍

@MiroslavDionisiev MiroslavDionisiev merged commit 0cadb01 into scratchfoundation:develop Aug 28, 2024
cwillisf pushed a commit that referenced this pull request Feb 20, 2025
… occupied by a shadow block (#8)

* chore: format engine/blocks.js

* fix: restore shadow blocks when removing a block from an input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants