Fix stroke bounds for paths #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check was being done backwards-- we should have been checking if values were less than the current minimum with padding subtracted from the *values*, and greater than the current maximum with padding added, but we were subtracting padding from the *minimum* (and adding padding to the maximum). Instead, we now add padding to the minimum and subtract it from the maximum, which is equivalent to subtracting padding from the values when comparing them to the minimum and adding padding to the values when comparing them to the maximum.
|
@fsih Just wanted to make sure this hadn't fallen off your radar--this fix has already been merged upstream so it shouldn't cause too much trouble here. |
|
Why hasn't this been merged already? (Looks like this HAS fallen off fsih's radar.) |
|
I don't think they're part of the Scratch team anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See paperjs#1825
Related issues
Checklist
npm run jshintpasses)