test: Fix expectations on Windows

scrapy · Jul 18, 2024 · 7b539ae · 7b539ae
1 parent aa60da5
commit 7b539ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/integration_tests/test_webservice.py b/integration_tests/test_webservice.py
@@ -211,7 +211,7 @@ def test_delversion_nonexistent_project():
                 f"[Errno 2] No such file or directory: '{BASEDIR}/eggs/nonexistent/noegg.egg'"
                 if sys.platform != "win32" else
                 "[WinError 3] The system cannot find the path specified: "
-                f"{BASEDIR}\\\\eggs\\\\nonexistent\\\\noegg.egg'"
+                f"'{BASEDIR}\\\\eggs\\\\nonexistent\\\\noegg.egg'"
             ),
         },
         data={"project": "nonexistent", "version": "noegg"},

diff --git a/scrapyd/webservice.py b/scrapyd/webservice.py
@@ -269,6 +269,8 @@ def render_POST(self, txrequest, project):
         UtilsCache.invalid_cache(project)
         return {"node_name": self.root.nodename, "status": "ok"}
 
+    # Minor security note: Submitting a non-existent project or version when using the default eggstorage can produce
+    # an error message that discloses the resolved path to the eggs_dir.
     def _delete_version(self, project, version=None):
         self.root.eggstorage.delete(project, version)
         self.root.update_projects()