Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme content type and Travis deploy step #21

Conversation

anubhavp28
Copy link
Collaborator

@anubhavp28 anubhavp28 commented Feb 12, 2022

long_description_content_type was incorrectly set to text/markdown in setup.py. Also, pip has dropped support for Python 2.7 causing the Travis deploy step to fail.

@Gallaecio Gallaecio added bug Something isn't working good first issue Good for newcomers labels Feb 13, 2022
@anubhavp28
Copy link
Collaborator Author

@Gallaecio Could you review this?

@Gallaecio Gallaecio removed bug Something isn't working good first issue Good for newcomers labels Feb 14, 2022
@Gallaecio
Copy link
Member

@anubhavp28 Sorry, I thought it was an issue instead of a pull request 🤦

@anubhavp28 anubhavp28 merged commit aed7040 into scrapy:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants