-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for set type #84
base: master
Are you sure you want to change the base?
Conversation
I must say, when you said keeping |
@Gallaecio I honestly had the same initial idea, but then I double-checked how it used to work and started to doubt the whole idea. Ultimately though, I decided to make it backwards compatible and push it anyway, to have the conversation at least. Thinking about it again today, maybe it's better not to include the set at all as it might break existing code even more... |
Adding I think it's good to keep backwards compatibility, otherwise, this could cause many problems. If someone wants to actually have a |
@ava7 I didn't mind to steal your thunder here, I just created the PR to test my assumptions. |
@VMRuiz It's alright mate, nothing to steal here, the more opinions the better :) |
I just checked that in 1.1.0 using Based on that, I propose to treat the old behavior as a bug and do not try to fix it. The downside to this is that someone that was relaying on the behavior may be surprised when he is not longer getting a list of values but a list of sets of values. |
In the previous version (1.1.0), adding a set would return a list:
In version 1.2.0, a list o af set would be returned:
This PR is aimed to keep the previous behaviour. Follow-up from #51 (comment)