Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pre commit #145

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Adding pre commit #145

merged 3 commits into from
Apr 11, 2024

Conversation

emarondan
Copy link

  • added config files for pre-commit hooks
  • excluding bandit checks and test dir
  • added pre-commit to github CI checks
  • running pre-commit hooks for all the code

Gallaecio
Gallaecio reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove security from .github/workflows/checks.yml.

@emarondan
Copy link
Author

Need to remove security from .github/workflows/checks.yml.

Done in 24ae330

@Gallaecio Gallaecio merged commit 94eecb1 into scrapy:master Apr 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emarondan @Gallaecio