Do not try to decode body of Response#175
Open
whalebot-helmsman wants to merge 6 commits intoscrapy-plugins:masterfrom
Open
Do not try to decode body of Response#175whalebot-helmsman wants to merge 6 commits intoscrapy-plugins:masterfrom
whalebot-helmsman wants to merge 6 commits intoscrapy-plugins:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 92.67% 92.66% -0.02%
==========================================
Files 9 9
Lines 587 586 -1
Branches 118 118
==========================================
- Hits 544 543 -1
Misses 21 21
Partials 22 22
Continue to review full report at Codecov.
|
Contributor
|
@whalebot-helmsman I’ve found this pull request while reviewing some old pull requests. What would the next steps be for this request? |
Contributor
Author
|
I think we should merge it. Any thoughts @kmike ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussion in #173
Decoding body of Response using only utf-8 is right way to fail. It is better to skip decoding at all.
There is two problems with integration tests at this moment - scrapy/scrapy#3210 (comment) and scrapy/scrapy#3210 (comment) . Considering this, no integration tests added
Fixing Integration tests requires effort separate from proposed changes