Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ItemValidationPipeline using __setitem__ without ItemAdapter #415

Merged
merged 7 commits into from
Aug 31, 2023

Conversation

VMRuiz
Copy link
Collaborator

@VMRuiz VMRuiz commented Aug 30, 2023

No description provided.

@VMRuiz
Copy link
Collaborator Author

VMRuiz commented Aug 30, 2023

I don't think we need to conver to dict here and here but I'm keeping the same logic for now

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40% 🎉

Comparison is base (e070dd8) 78.64% compared to head (be24262) 79.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   78.64%   79.05%   +0.40%     
==========================================
  Files          73       73              
  Lines        3152     3151       -1     
  Branches      528      528              
==========================================
+ Hits         2479     2491      +12     
+ Misses        598      590       -8     
+ Partials       75       70       -5     
Files Changed Coverage Δ
spidermon/contrib/scrapy/pipelines.py 97.72% <100.00%> (+13.45%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VMRuiz VMRuiz merged commit ea21cee into scrapinghub:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants