Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with JobMetadata not longer supporting __setitem__ method #404

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

VMRuiz
Copy link
Collaborator

@VMRuiz VMRuiz commented Jun 30, 2023

Fixes #403

I did my best to test it locally, but I was not able to test it in a real Scrapy Cloud enviroment.

@VMRuiz VMRuiz requested review from wRAR, rennerocha and Gallaecio June 30, 2023 08:59
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.14 🎉

Comparison is base (e697dbe) 76.37% compared to head (3c7627e) 77.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   76.37%   77.52%   +1.14%     
==========================================
  Files          73       73              
  Lines        3103     3101       -2     
  Branches      518      516       -2     
==========================================
+ Hits         2370     2404      +34     
+ Misses        663      626      -37     
- Partials       70       71       +1     
Impacted Files Coverage Δ
spidermon/contrib/actions/jobs/tags.py 97.05% <100.00%> (+97.05%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VMRuiz VMRuiz force-pushed the issue-403-custom-job-tags branch from 2bd22e8 to 856bc46 Compare June 30, 2023 09:02
@VMRuiz VMRuiz force-pushed the issue-403-custom-job-tags branch from d001c1d to 068e305 Compare June 30, 2023 09:04
@Gallaecio
Copy link
Member

I did my best to test it locally, but I was not able to test it in a real Scrapy Cloud enviroment.

While the code looks good to me, it may be best to get a manual test on Scrapy Cloud before merging.

@VMRuiz
Copy link
Collaborator Author

VMRuiz commented Jul 4, 2023

I did my best to test it locally, but I was not able to test it in a real Scrapy Cloud enviroment.

While the code looks good to me, it may be best to get a manual test on Scrapy Cloud before merging.

I forgot this is a public repo 😅. I was able to test it, works as expected.

@VMRuiz VMRuiz merged commit 1993f46 into scrapinghub:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using custom job tags action class
3 participants