Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BaseStatMonitor to implement built-in item count monitor #326

Merged

Conversation

rennerocha
Copy link
Collaborator

Use the new BaseStatMonitor to implement Item Count Monitor

@rennerocha rennerocha added this to the 1.16.0 milestone Dec 14, 2021
@rennerocha rennerocha force-pushed the built-in-item-count-monitor branch from 4bbc6a6 to 8f3d756 Compare December 14, 2021 15:59
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #326 (8f3d756) into master (b40c322) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   73.92%   73.85%   -0.07%     
==========================================
  Files          68       68              
  Lines        2991     2983       -8     
  Branches      451      450       -1     
==========================================
- Hits         2211     2203       -8     
  Misses        718      718              
  Partials       62       62              
Impacted Files Coverage Δ
spidermon/contrib/scrapy/monitors.py 98.06% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40c322...8f3d756. Read the comment docs.

Copy link
Contributor

@further-reading further-reading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rennerocha rennerocha merged commit f7e848c into scrapinghub:master Dec 22, 2021
@rennerocha rennerocha deleted the built-in-item-count-monitor branch December 22, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants